Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Pipenv terminal with pipenv shell #2855

Closed
iddan opened this issue Oct 11, 2018 · 3 comments
Closed

Open Pipenv terminal with pipenv shell #2855

iddan opened this issue Oct 11, 2018 · 3 comments
Assignees
Labels
area-terminal feature-request Request for new features or functionality

Comments

@iddan
Copy link

iddan commented Oct 11, 2018

Environment data

  • VS Code version: 1.28.0
  • Extension version (available under the Extensions sidebar): 2018.9.0
  • OS and version: macOS Mojave 10.14
  • Python version (& distribution if applicable, e.g. Anaconda): 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Actual behavior

When pipenv venv detected terminal is opened by:

source $VENV_LOCATION/bin/activate

Expected behavior

Terminal to open with:

pipenv shell

Why?

Because that way .env would be loaded automatically and activating shell would be encapsulated

@wcass77

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@DonJayamanne DonJayamanne self-assigned this Jan 2, 2019
@DonJayamanne DonJayamanne changed the title Feature Request: Open Pipenv terminal with pipenv shell Open Pipenv terminal with pipenv shell Jan 8, 2019
@DonJayamanne
Copy link

Problems

  • Open a folder in a terminal and create a pip env
  • Next open VSC and open a completely different folder
  • VSC will not identify the above pipenv as a virtual env

Cause:

  • Extension has discovered all interpreters and above pipenv is not detected as a pipenv (unfortunately its treated as a virtual env, pipenv doesn't provide an api to get around this).
  • Now above env is treated as virtual env
  • Next when we open the folder which has the pipenv mapped to it, the pipenv will not get activated correctly.

@ghost ghost removed the needs PR label Jan 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants