Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pipenv activation #4105

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

DonJayamanne
Copy link

For #2855

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 23, 2019
@karrtikr karrtikr self-assigned this Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #4105 into master will decrease coverage by 1%.
The diff coverage is 73%.

@@           Coverage Diff           @@
##           master   #4105    +/-   ##
=======================================
- Coverage      79%     79%   -<1%     
=======================================
  Files         407     407            
  Lines       18644   18733    +89     
  Branches     3007    3032    +25     
=======================================
+ Hits        14608   14669    +61     
- Misses       4033    4054    +21     
- Partials        3      10     +7
Flag Coverage Δ
#Linux 68% <82%> (ø) ⬇️
#Windows 68% <82%> (ø) ⬇️
#macOS 68% <82%> (+1%) ⬆️

@DonJayamanne DonJayamanne merged commit 57eda27 into microsoft:master Jan 23, 2019
DonJayamanne added a commit that referenced this pull request Jan 25, 2019
@DonJayamanne DonJayamanne deleted the fixesFor2855 branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants