Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App manifest 1.19 and devPreview October updates #11636

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

erikadoyle
Copy link
Contributor

@erikadoyle erikadoyle commented Sep 26, 2024

Note: Requirements Targeting changes covered here: #11018

Updates for 1.19 and devPreview manifest references:

  • copilotExtensions > copilotAgents
  • defaultLocalizationFile

Also updated:

  • Updated loc schema reference from 1.16 to 1.19 (1.17 changes included)
  • What's new (Preview, GA)
  • Link to Copilot agent loc guidance from Teams loc article

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 129 link
msteams-platform/resources/schema/manifest-schema.md 86 113 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit cc35aa5:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/resources/schema/manifest-schema-dev-preview.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@erikadoyle erikadoyle marked this pull request as draft September 26, 2024 21:16
@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 129 link
msteams-platform/resources/schema/manifest-schema.md 86 113 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 33b76b9:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/resources/schema/manifest-schema-dev-preview.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/localization-schema.md 99 4 link
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 129 link
msteams-platform/resources/schema/manifest-schema.md 86 113 link
msteams-platform/whats-new.md 90 91 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 325a322:

💡 Validation status: suggestions

File Status Preview URL Details
msteams-platform/resources/schema/localization-schema.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema.md 💡Suggestion View Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema-dev-preview.md ✅Succeeded View
msteams-platform/whats-new.md ✅Succeeded View

msteams-platform/resources/schema/localization-schema.md

  • Line 11, Column 173: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/en-us/json-schemas/teams/v1.19/MicrosoftTeams.Localization.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 14, Column 136: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

msteams-platform/resources/schema/manifest-schema.md

  • Line 11, Column 180: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@erikadoyle erikadoyle marked this pull request as ready for review October 3, 2024 00:24
@erikadoyle erikadoyle changed the title [WIP] Stage pending manifest updates App manifest 1.19 and devPreview October updates Oct 3, 2024
Copy link
Collaborator

@v-ramyas5 v-ramyas5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erikadoyle,
Have shared some small suggestions. Please accommodate.
Since, we have decided to add the 'Type' column in the property table even if all the properties are strings to make it clear to the developers and to follow consistency, have added that also as a suggestion.

msteams-platform/resources/schema/manifest-schema.md Outdated Show resolved Hide resolved
msteams-platform/resources/schema/manifest-schema.md Outdated Show resolved Hide resolved
msteams-platform/resources/schema/manifest-schema.md Outdated Show resolved Hide resolved
msteams-platform/resources/schema/manifest-schema.md Outdated Show resolved Hide resolved
msteams-platform/resources/schema/manifest-schema.md Outdated Show resolved Hide resolved
Co-authored-by: v-ramyas5 <168160268+v-ramyas5@users.noreply.github.com>
@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/localization-schema.md 99 4 link
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 130 link
msteams-platform/resources/schema/manifest-schema.md 86 114 link
msteams-platform/whats-new.md 90 91 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit d1c89ea:

💡 Validation status: suggestions

File Status Preview URL Details
msteams-platform/resources/schema/localization-schema.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema-dev-preview.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema.md 💡Suggestion View Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/whats-new.md ✅Succeeded View

msteams-platform/resources/schema/localization-schema.md

  • Line 11, Column 173: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/en-us/json-schemas/teams/v1.19/MicrosoftTeams.Localization.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 14, Column 136: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

msteams-platform/resources/schema/manifest-schema-dev-preview.md

  • Line 390, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

msteams-platform/resources/schema/manifest-schema.md

  • Line 11, Column 180: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/localization-schema.md 99 4 link
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 130 link
msteams-platform/resources/schema/manifest-schema.md 86 114 link
msteams-platform/whats-new.md 90 91 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 85b7569:

💡 Validation status: suggestions

File Status Preview URL Details
msteams-platform/resources/schema/localization-schema.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema-dev-preview.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema.md 💡Suggestion View Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/whats-new.md ✅Succeeded View

msteams-platform/resources/schema/localization-schema.md

  • Line 11, Column 173: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/en-us/json-schemas/teams/v1.19/MicrosoftTeams.Localization.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 14, Column 136: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

msteams-platform/resources/schema/manifest-schema-dev-preview.md

  • Line 390, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

msteams-platform/resources/schema/manifest-schema.md

  • Line 11, Column 180: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/localization-schema.md 99 4 link
msteams-platform/resources/schema/manifest-schema-dev-preview.md 85 130 link
msteams-platform/resources/schema/manifest-schema.md 86 114 link
msteams-platform/whats-new.md 90 91 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit e900bed:

💡 Validation status: suggestions

File Status Preview URL Details
msteams-platform/resources/schema/localization-schema.md 💡Suggestion View Details
msteams-platform/resources/schema/manifest-schema.md 💡Suggestion View Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema-dev-preview.md ✅Succeeded View
msteams-platform/whats-new.md ✅Succeeded View

msteams-platform/resources/schema/localization-schema.md

  • Line 11, Column 173: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/en-us/json-schemas/teams/v1.19/MicrosoftTeams.Localization.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 14, Column 136: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

msteams-platform/resources/schema/manifest-schema.md

  • Line 11, Column 180: [Suggestion: other-site-link-broken - See documentation] Link 'https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@erikadoyle
Copy link
Contributor Author

Thank you very much @v-ramyas5! I've incorporated your suggestions.

@v-ramyas5
Copy link
Collaborator

Thank you very much @v-ramyas5! I've incorporated your suggestions.

Thank you @erikadoyle for incorporating the changes.

@v-ramyas5 v-ramyas5 self-requested a review October 4, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants