Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Integration and Error Resolution #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ESLint Integration and Error Resolution #79

wants to merge 1 commit into from
+2,623 −1,671

Conversation

samar12-rad
Copy link

Description:
This PR introduces ESLint into the project to enhance code quality and maintainability. It includes the following changes:

  • ESLint Configuration: Added a comprehensive ESLint configuration file to enforce coding standards across the codebase.
  • Error Resolution: Fixed all identified linting errors, including issues related to code style, prop validation, and other best practices.
  • Code Quality Improvement: Ensured consistent code formatting and reduced potential bugs by adhering to established coding standards.

Impact:

  • Improved code readability and maintainability.
  • Enhanced collaboration by standardizing code style across the project.

Next Steps:

  • Review the ESLint rules and configurations to ensure they align with the team's preferences.
  • Monitor for any new linting errors as development continues.

Related Issues:

Thank you for reviewing this PR!

@samar12-rad
feat: Add ESLint configuration and resolve all linting errors
984d80a 
- Integrated ESLint into the project for improved code quality and consistency.
- Fixed all identified linting errors, including style and prop validation issues.
- Updated .eslintrc configuration to enforce coding standards across the codebase.
@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ratna-supermarket-mini-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:37pm
ratna-supermarket-x3ah ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:37pm

@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024

@samar12-rad is attempting to deploy a commit to the minavkaria's projects Team on Vercel.

A member of the Team first needs to authorize it.

@samar12-rad
Copy link
Author

There were total 34 files which had multiple erros in each of those.
Those errors were resolved manually and
The site was got proper inspection for its working.

Further Improvements:
From now on, on one can push unused data in the repo

@samar12-rad
Copy link
Author

Work done! on top priority

@MinavKaria
Copy link
Owner

@samar12-rad It may take some time to merge your PR

@samar12-rad
Copy link
Author

What is the issue @MinavKaria ?

@samar12-rad
Copy link
Author

I will resolve branch conflicts.

@MinavKaria
Copy link
Owner

Please try not break any feature
@samar12-rad

@samar12-rad
Copy link
Author

Ok

@MinavKaria
Copy link
Owner

@samar12-rad Hey resolve the conflict in the weekends, bcoz I'll need to review the code as changes are too much. I'll give level3 to this as there too many eslint issues resolved

@samar12-rad
Copy link
Author

You are right. There are too many conflicts, I'll do it on weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samar12-rad @MinavKaria