Add NearConfig to Near Safe Constructor

[bh2smith]

PR Type

Enhancement

---

Description

• Replaced TransactionManager with NearSafe in the examples/send-tx.ts file.
• Updated the export in src/index.ts to use near-safe instead of tx-manager.
• Introduced the NearSafe class and NearSafeConfig interface in src/near-safe.ts.
• Updated the create method in NearSafe to use the new configuration interface.

---

Changes walkthrough 📝

Relevant files

Enhancement

send-tx.ts Update example to use NearSafe instead of TransactionManager examples/send-tx.ts Replaced TransactionManager with NearSafe in the import statement. Updated the instantiation from TransactionManager.create to NearSafe.create. +2/-2      index.ts Update export to use NearSafe                                                        src/index.ts Changed export from tx-manager to near-safe. +1/-1      near-safe.ts Introduce NearSafe class and configuration                              src/near-safe.ts Added import for NearConfig. Introduced NearSafeConfig interface. Renamed TransactionManager class to NearSafe. Updated the create method to use NearSafeConfig. +20/-13

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[mintbase-codium-pr-agent]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Missing Validation The create method in NearSafe class does not validate the configuration object before using it. This could lead to runtime errors if required properties are missing or invalid.

[mintbase-codium-pr-agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Reliability	Implement error handling for asynchronous operations Add error handling for the asynchronous operations within the create method to prevent unhandled promise rejections and improve reliability. src/near-safe.ts [67-71] static async create(config: NearSafeConfig): Promise<NearSafe> { - const { pimlicoKey } = config; - const [nearAdapter, safePack] = await Promise.all([ - setupAdapter({ ...config }), - ContractSuite.init(), - ]); + try { + const { pimlicoKey } = config; + const [nearAdapter, safePack] = await Promise.all([ + setupAdapter({ ...config }), + ContractSuite.init(), + ]); + } catch (error) { + console.error("Failed to create NearSafe:", error); + throw error; + } Suggestion importance[1-10]: 10 Why: Adding error handling for asynchronous operations is crucial for preventing unhandled promise rejections, which improves the reliability and robustness of the code.	10
Possible issue	Validate required parameters to ensure they are provided Ensure that the safeSaltNonce is always provided to avoid potential issues with generating the safe address. src/near-safe.ts [75-77] +if (!config.safeSaltNonce) { + throw new Error("safeSaltNonce is required to generate a safe address."); +} const safeAddress = await safePack.addressForSetup( setup, config.safeSaltNonce ); Suggestion importance[1-10]: 9 Why: Ensuring that required parameters like safeSaltNonce are provided helps prevent runtime errors and potential issues with generating the safe address, improving code reliability.	9
Maintainability	Replace hardcoded values with configurable environment variables Replace the hardcoded chain ID with a configurable option to enhance flexibility and maintainability. examples/send-tx.ts [15] -const chainId = 11155111; +const chainId = process.env.CHAIN_ID || 11155111; Suggestion importance[1-10]: 8 Why: Replacing hardcoded values with environment variables enhances flexibility and maintainability, making the code easier to configure for different environments.	8
Best practice	Use structured logging for better readability and maintainability Replace the verbose console log with a structured logging approach to improve readability and maintainability. src/near-safe.ts [79-84] -console.log(` - Near Adapter: - Near Account ID: ${nearAdapter.nearAccountId()} - MPC EOA: ${nearAdapter.address} - Safe: ${safeAddress} -`); +console.log({ + message: "Near Adapter details", + details: { + NearAccountID: nearAdapter.nearAccountId(), + MPC_EOA: nearAdapter.address, + Safe: safeAddress + } +}); Suggestion importance[1-10]: 7 Why: Structured logging improves readability and maintainability by providing a clear and consistent format for log messages, making it easier to parse and analyze logs.	7