Skip to content

Commit

Permalink
test: fix watch mode test flake
Browse files Browse the repository at this point in the history
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
MoLow committed Oct 12, 2022
1 parent 7de120a commit 72bf89e
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions test/sequential/test-watch-mode.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ describe('watch mode', { concurrency: true, timeout: 60_0000 }, () => {
const file = fixtures.path('watch-mode/failing.js');
const { stderr, stdout } = await spawnWithRestarts({ file });

// Use match first to pretty print diff on failure
assert.match(stderr, /Error: fails\r?\n/);
assert.strictEqual(stderr.match(/Error: fails\r?\n/g).length, 2);
// Test that failures happen once per restart
assert(stderr.match(/Error: fails\r?\n/g).length >= 2);
assertRestartedCorrectly({
stdout,
messages: { completed: `Failed running ${inspect(file)}`, restarted: `Restarting ${inspect(file)}` },
Expand Down Expand Up @@ -206,7 +208,9 @@ describe('watch mode', { concurrency: true, timeout: 60_0000 }, () => {
});
});

it('should not load --import modules in main process', async () => {
it('should not load --import modules in main process', {
skip: 'enable once --import is backported',
}, async () => {
const file = createTmpFile('');
const imported = fixtures.fileURL('watch-mode/process_exit.js');
const args = ['--import', imported, file];
Expand Down

0 comments on commit 72bf89e

Please sign in to comment.