Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 11 everywhere #649

Merged
merged 5 commits into from
Jul 7, 2024
Merged

Conversation

matt-ramotar
Copy link
Collaborator

No description provided.

msfjarvis and others added 2 commits July 7, 2024 22:23
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Matt Ramotar <matt.ramotar@uber.com>
@matt-ramotar matt-ramotar mentioned this pull request Jul 7, 2024
10 tasks
@matt-ramotar matt-ramotar changed the title Java 11 Use Java 11 everywhere Jul 7, 2024
@digitalbuddha
Copy link
Contributor

is this raising min sdk?

@matt-ramotar
Copy link
Collaborator Author

Making it consistent was my intention, but now I'm seeing that I inadvertently raised it when I added the convention plugin (I pulled the convention plugin from the paging repo). Will make consistent at 24,

@digitalbuddha
Copy link
Contributor

Thanks for reverting. Maybe add release notes for last version just in case

@matt-ramotar matt-ramotar marked this pull request as ready for review July 7, 2024 18:32
@matt-ramotar matt-ramotar merged commit 83e5f8d into main Jul 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants