Merge the Xcode-10.1 Bazel work into master #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on#327) This change makes Bluepill usable with the Bazel build system by providing an ios_bluepill_test_runner() rule compatible with rules_apple's ios_test_runner() rule. Besides the major refactoring of code: * Fix a bug where the environment variables set in the config file passed to bluepill weren't being propagated to bp. * Fix a bug where bluepill was not doing the weak_linking setup trick so if multiple versions of Xcode were being used, it wasn't clear which private framework it ended up loading.
oliverhu
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks big because Git is stupid. It's essentially the same rename's as #327