Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setupWeakLinking asserting if bluepill is launched without a full executable path #346

Merged

Conversation

ksuther
Copy link
Contributor

@ksuther ksuther commented Jul 24, 2019

Pass argc and argv and then rewrite argv so the first argument uses the full path to the executable.

Otherwise running bluepill from a shell will fail because argv[0] will be just bluepill rather than the full path to the executable.

Introduced in #327.

…ll executable path

Pass argc and argv and then rewrite argv so the first argument uses the full path to the executable
@oliverhu
Copy link
Member

There is a unit test failure: testReportWithAppHangingTestsShouldReturnFailure, ((exitCode == BPExitStatusTestTimeout) is true) failed . I'll kicking off the CI again to see if it is a flakiness issue.

@ksuther
Copy link
Contributor Author

ksuther commented Jul 25, 2019

The failure seems like something bazel-related or signing-related:

ERROR: /Users/vsts/agent/2.154.3/work/1/s/bluepill/BUILD.bazel:26:1: error executing shell command: '/bin/bash -c cp bazel-out/apl-darwin_x86_64-fastbuild/bin/bluepill/bluepill.__internal__.apple_binary_lipobin bazel-out/darwin-fastbuild/bin/bluepill/bluepill
export CODESIGN_ALLOCATE=${DEVELOPER_D...' failed (Exit 1)
Traceback (most recent call last):
  File "/private/var/tmp/_bazel_vsts/3d8bb33834c44268ed5d56850014916e/execroot/__main__/bazel-out/host/bin/external/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.runfiles/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.py", line 162, in <module>
    sys.exit(main(sys.argv))
  File "/private/var/tmp/_bazel_vsts/3d8bb33834c44268ed5d56850014916e/execroot/__main__/bazel-out/host/bin/external/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.runfiles/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.py", line 156, in main
    filtered_stderr = _filter_codesign_output(stderr)
  File "/private/var/tmp/_bazel_vsts/3d8bb33834c44268ed5d56850014916e/execroot/__main__/bazel-out/host/bin/external/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.runfiles/build_bazel_rules_apple/tools/codesigningtool/codesigningtool.py", line 116, in _filter_codesign_output
    for line in codesign_output.split("\n"):
TypeError: a bytes-like object is required, not 'str'

@oliverhu oliverhu merged commit fbd05ec into MobileNativeFoundation:master Jul 25, 2019
@ksuther ksuther deleted the setupWeakLinking-fix branch July 25, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants