Housekeeping. Misc project changes #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 12.3 also targets Apple Silicon so it will try to build the for arm. Upon the frameworks that Bluepill links to, CoreSimulator has arm64e so Xcode would refuse to link to it. To make Bluepill build with Xcode 12.3 here we pin ARCH to x86_64
Extracted variable DerivedDataPath in build.sh Remoted schemes "bp-tests" and "bluepill-tests" Changed schemes "bp" and "bluepill" to include related test targets Changed schemes in build.sh to build and test "bp" and "bluepill" schemes Hide bplib scheme since it's setup as a target dependency of bp and bluepill The workflow would be: Before doing anything, run build-for-testing (CMD+Shift+U) for BPSampleApp Work on bp or bluepill targets, to run tests, use test button or (CMD+U)
|
This is preparations for Xcode 12.3 |
ob
previously approved these changes
Jan 11, 2021
Good point! I'll remove it for master. Will update this PR later, after rebalancing the tests and fix the test failures. |
|
Fixed typo Always collect xcresult. Even when the tests fail. Also added the collect xcresult in master workflow.
When building with Xcode with Simulator Xcode will pick the host arch. For now it's only x86_64 This change aligns the artifact of the sample app for CI and local dev. We will figure out what to do with Apple Silicon when we start to support it.
Refactored bluepill.sh to reuse code for running tests Changed github workflow yml's to run tests with 3 machines Added base test case class BPIntTestCase to split BluepillTests which runs for an hour Created new test case BPReportTests to extract some tests out of BluepillTests to run on another machine
chenxiao0228
force-pushed
the
pin-arch
branch
from
079bf77
to
846bf82
Compare
chenxiao0228
changed the title
chenxiao0228
changed the title
|
@ob This PR is ready for review. |
ob
approved these changes
Jan 19, 2021
It's explained in this commit msg. |
RainNapper
pushed a commit
to RainNapper/bluepill
that referenced
this pull request
Apr 14, 2021
* Specify ARCHS for bp and bluepill projects Xcode 12.3 also targets Apple Silicon so it will try to build the for arm. Upon the frameworks that Bluepill links to, CoreSimulator has arm64e so Xcode would refuse to link to it. To make Bluepill build with Xcode 12.3 here we pin ARCH to x86_64 * Scheme clean up Extracted variable DerivedDataPath in build.sh Remoted schemes "bp-tests" and "bluepill-tests" Changed schemes "bp" and "bluepill" to include related test targets Changed schemes in build.sh to build and test "bp" and "bluepill" schemes Hide bplib scheme since it's setup as a target dependency of bp and bluepill The workflow would be: Before doing anything, run build-for-testing (CMD+Shift+U) for BPSampleApp Work on bp or bluepill targets, to run tests, use test button or (CMD+U) * Added build step to capture xcresult files for analysis * Build the sample app with x86_64 only When building with Xcode with Simulator Xcode will pick the host arch. For now it's only x86_64 This change aligns the artifact of the sample app for CI and local dev. We will figure out what to do with Apple Silicon when we start to support it. * Use 3 machines to run tests Refactored bluepill.sh to reuse code for running tests Changed github workflow yml's to run tests with 3 machines Added base test case class BPIntTestCase to split BluepillTests which runs for an hour Created new test case BPReportTests to extract some tests out of BluepillTests to run on another machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 12.3 also targets Apple Silicon so it will try to build the for arm.
Upon the frameworks that Bluepill links to, CoreSimulator has arm64e so
Xcode would refuse to link to it. To make Bluepill build with Xcode 12.3
here we pin ARCH to x86_64
Simplified project structure, now we can focus on
bpandbluepillschemes and cmd+u runs tests for them instead of having to switch to test schemes.Refactors bluepill.sh and some test cases. Try to reduce PR check time from 1 hr to ~35min by splitting the check to 3 machines.