Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 15.1 #568

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Xcode 15.1 #568

merged 5 commits into from
Jan 29, 2024

Conversation

nanwng
Copy link
Collaborator

@nanwng nanwng commented Jan 5, 2024 •
edited
Loading

Support Xcode 15.1

  • Since Xcode 15, the simulator eats up more machine resources. So made sure we boot and delete the simulators correctly with better status check
  • Increased test bundle connection timeout to address the performance issue
  • There are cases where a test bundle disconnects but bp keeps waiting to check for some output. Added a timeout config (testBundleDisconnectTimeout) to address that
  • Made sure to call new private delegate functions
  • Added a new test batch to account for slower test run in Xcode 15.

@nanwng
Support Xcode 15.0
75ad8bb 
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
@nanwng
add testBundleDisconnectTimeout
ca28d77 
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
@nanwng
try xcode 15.1
f478fc7 
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
@nanwng
Fix test flakiness
4a0bd76 
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
@nanwng
Split tests
988517f 
Signed-off-by: Nan Wang <nanwang1101@yahoo.com>
@nanwng nanwng marked this pull request as ready for review January 12, 2024 20:25
@nanwng nanwng requested a review from a team as a code owner January 12, 2024 20:25
chenxiao0228
chenxiao0228 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@chenxiao0228 chenxiao0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so many hardcoded timeout everywhere.

We should probably pull them out into a separate header.

bluepill/bluepill.xcodeproj/project.pbxproj Show resolved Hide resolved
bp/bp.xcodeproj/project.pbxproj Show resolved Hide resolved
@nanwng nanwng merged commit a3f6f4b into master Jan 29, 2024
5 checks passed
@nanwng nanwng deleted the nanwng/xc15-fork branch January 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxiao0228 chenxiao0228 chenxiao0228 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanwng @chenxiao0228