Fix for special window close case under SDL #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cra0zy This one's good to go IMO. |
harry-cpp
requested changes
Nov 14, 2018
| @@ -80,6 +80,8 @@ public override bool IsBorderless | |||
| } | |||
| } | |||
|
|
|||
| internal uint Id; | |||
There was a problem hiding this comment.
The class is internal, so this should be public and next to other public variables.
Also use int? as we have no idea how SDL picks these ids, there is a very small chance that the dummy window we create sends events, and we probably don't want that.
harry-cpp
approved these changes
Nov 14, 2018
tomspilman
changed the title
tomspilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the window id so we only handle window events for the window we created. Also sets the exit flag when that window is closed. Fixes #6432.