Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBO-357 - add kdsf publication type classification containing xpath ... #418

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

UBO-357 - add kdsf publication type classification containing xpath ... #418

wants to merge 3 commits into from

Conversation

kkrebs
Copy link
Contributor

@kkrebs kkrebs commented Aug 29, 2024 •
edited
Loading

... based classification mapping using genre and host genre

https://mycore.atlassian.net/browse/UBO-357

@kkrebs
UBO-357 - add kdsf publication type classification containing xpath ...
57bd7f3 
... based classification mapping using genre and host genre
@kkrebs kkrebs requested review from kponten and erodde August 29, 2024 15:47
erodde
erodde approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@erodde erodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested branch locally, Pu11 classification is written into mods. Code changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erodde erodde erodde approved these changes

@kponten kponten Awaiting requested review from kponten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkrebs @erodde