Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Deprecate specs. Remove Move model's dependencies on expansion AST #15480

Merged
merged 25 commits into from
Jan 5, 2024

Conversation

tnowacki
Copy link
Contributor

@tnowacki tnowacki commented Dec 22, 2023

Description

  • Removed the move-model's dependency on the expansion AST, which requires deprecating specs
  • Removed spec usage from all files
  • Specs will still parse, but be marked as deprecated

Test Plan

  • Ran tests

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Move has deprecated specs as the prover is not in active development

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 3:21am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 3:21am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 3:21am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 3:21am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 3:21am

Copy link

vercel bot commented Dec 22, 2023

@tnowacki is attempting to deploy a commit to the Sui Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this brought in from a different diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah its stacked on #15267, which has been stuck by a borked test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this brought in from a different diff?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this brought in from a different diff?

Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the one question about the interpreter tests ✂️

@@ -1,26 +0,0 @@
[package]
name = "bytecode-interpreter-testsuite"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this testsuite need to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to bring it back (except for certain tests). I got a bit excited :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants