Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly handle empty <description> tags in hw_commands and fsw_commands #9

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

dandelany
Copy link
Collaborator

@dandelany dandelany commented Jun 7, 2024

Related to NASA-AMMOS/aerie#1466

Kind of a devious bug related to destructuring, you'd expect Typescript to complain about something like this, because myCollection.things can be undefined:

interface ThingCollection {
  things?: Array<Thing>
}
const myCollection: ThingCollection = getThingCollection();
const [thing] = myCollection.things;

... but this compiles and throws a runtime error. Might be good to do a scan for any other similar bugs before merging.

Copy link

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We probably should bump the version to 1.0.6, as we are using 1.0.5 right now.

@dandelany
Copy link
Collaborator Author

Thanks - bumped the version. Also sneaked in one more edge-case fix in e14cb2d - this case already threw an error, its now more descriptive. Merging this & I will publish 1.0.6 on NPM also.

@dandelany dandelany merged commit 457b139 into develop Jun 12, 2024
1 check passed
@dandelany dandelany deleted the hotfix/handle-empty-tags branch June 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants