update feedback form with correct link

[naomatheus]

updates feedback form to open in new tab

[alukach]

Can you provide more backstory? Why are we switching from the earthdata feedback form to Google forms?

How did window.feedback get set? Should we remove the code that does that operation?

[naomatheus]

Backstory

Yea, this is in #525
@alukach

[alukach]

I think we still need to remove the kruft around setting up the old feedback form if we're not using that anymore.

See:

admg-casei/src/components/seo.js

Lines 31 to 45 in 52de652

	const FBM_URL = `https://fbm.earthdata.nasa.gov/for/CASEI/feedback.js`
	const { setIsFBMLoaded } = useContext(FBMContext)
	const handleChangeClientState = (newState, addedTags) => {
	if (addedTags && addedTags.scriptTags) {
	const foundScript = addedTags.scriptTags.find(
	({ src }) => src === FBM_URL
	)
	if (foundScript) {
	foundScript.onload = () => window.feedback.init({ showIcon: false })
	setIsFBMLoaded(true)
	}
	}
	}

admg-casei/src/components/inpage-nav.js

Lines 110 to 119 in 52de652

	{isFBMLoaded && (
	<Button
	action={() => {
	window.feedback.showForm()
	}}
	mode={POSITIVE}
	>
	Feedback
	</Button>
	)}

admg-casei/src/components/fbm-provider.js

Lines 1 to 22 in 52de652

	import React, { createContext, useState } from "react"
	import PropTypes from "prop-types"
	export const FBMContext = createContext({ isFBMLoaded: false })
	function FBMProvider({ children }) {
	const [isFBMLoaded, setIsFBMLoaded] = useState(
	typeof window !== "undefined" && window.feedback && window.feedback.showForm
	)
	return (
	<FBMContext.Provider value={{ isFBMLoaded, setIsFBMLoaded }}>
	{children}
	</FBMContext.Provider>
	)
	}
	FBMProvider.propTypes = {
	children: PropTypes.node.isRequired,
	}
	export default FBMProvider

admg-casei/gatsby-browser.js

Lines 24 to 27 in 52de652

	export const wrapRootElement = ({ element }) => {
	return <FBMProvider>{element}</FBMProvider>
	}

[alukach]

Reviewing a bit more about where we are already using the feedback form URL, I think it would be prudent to move this URL into a single constants file to make management of it a bit simpler:

admg-casei/src/pages/contact.js

Lines 67 to 72 in 52de652

	<ExternalLink
	url="https://docs.google.com/forms/d/e/1FAIpQLSfCQzZHtaDSiWNdwiJa3TIzsyhjEbYyyHwfrcwIKn_UmdVaKA/viewform?usp=sf_link"
	target="_blank"
	label="CASEI feedback"
	id="feedback form"
	/>{" "}

[naomatheus]

There was a good amount of unnecessary code. Requested changes add to maintainability. cc @alukach

[alukach]

thank @naomatheus, looking really good! I think there may be one or two other issues left, but almost there

[alukach]

Any idea why these were needed?

[naomatheus]

Yea,
gatsby doesn't allow "spatial_bounds"/"bounds" to be queried on the campaign type without this declaration.

source: https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization/#fixing-field-types