Fix/data products #536
Merged
Fix/data products #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tammo-Feldmann
commented
Jun 8, 2023
| @@ -49,7 +49,7 @@ const ExploreMap = ({ allData, filteredData, setGeoFilter, aoi, setAoi }) => { | |||
| } | |||
|
|
|||
| // Compute and set the initial bounding box | |||
| const [bbox] = useState(() => turfBbox(geojson)) | |||
There was a problem hiding this comment.
Since there was nowhere that we were using a setter here, I removed the useState hook.
edkeeble
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm fixing
I created a bug while removing spatial bounds at the campaign level. The explore map didn't get correctly parsed bbox inputs anymore. I added that back in.
I also forgot to replace an tag with a link in the products table and made that replacement here.
How you can test it
You can now see the explore map render bounding boxes for all campaigns again rather than throwing an error 😉 .