Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number Tables and place captions above table #681

Closed
5 tasks
Tracked by #771 ...
bwbaker1 opened this issue Apr 7, 2023 · 19 comments
Closed
5 tasks
Tracked by #771 ...

Number Tables and place captions above table #681

bwbaker1 opened this issue Apr 7, 2023 · 19 comments
Assignees

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Apr 7, 2023

### Description
There is a need to polish document tables to better fit with standard AGU/APA practices.

Tasks:

  • Tables need to be consecutively numbered in chronological order. The format should match figure numbers.
  • The table caption should be placed on top of the table. (see example below)

Acceptance Criteria:

  • Tables are consecutively and chronologically numbered
  • Table captions appear at the top of tables
  • PDFs are to ensure tables are numbered and captioned properly.

Image

@wrynearson
Copy link
Member

@bwbaker1 are you requesting this for the view mode or just the Document and Journal PDFs?

@bwbaker1
Copy link
Collaborator Author

@wrynearson Just both PDFs. If this is a relatively easy fix, great, otherwise it's not a high priority at the moment.

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Jun 5, 2023

@wrynearson What is the LOE to add figure, table, and equation numbers to both view mode and PDFs? This is coming from user feedback.

@wrynearson
Copy link
Member

Sorry I missed this @bwbaker1. Adding to the PDFs will be low LOE (we already have them for figures and equations) but more complex to add things back into the view mode. @frozenhelium, please correct me if I'm wrong.

@bwbaker1
Copy link
Collaborator Author

No worries @wrynearson. I want this issue (adding just to PDFs) to be our next priority following the PDF upload, as long as it is rather simple and fast to implement.
For Q4 planning, I would like to get a good estimate of the LOE to add all of these numberings to the view mode. This would be a good addition to better the user experience, so it's worth looking into. It's already on our planning document.

@wrynearson
Copy link
Member

@bwbaker1 this is ready for your review

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Oct 4, 2023

@wrynearson This looks good. However, images and equations are no longer numbered on the document PDF. See below. These are still numbered on the journal PDFs.

Document PDF
Screen Shot 2023-10-04 at 8 52 40 AM

Journal PDF
Screen Shot 2023-10-04 at 8 53 42 AM

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Oct 9, 2023

@wrynearson The document PDF still isn't generating correctly. See comment. Figures and equations are no longer numbered. And the table captions should be above the table (this is correct on the journal PDF).

@wrynearson wrynearson reopened this Oct 9, 2023
@wrynearson
Copy link
Member

@bwbaker1 could you try changing the document in some way and then trying again? @kamicut @sunu any ideas besides that Brad is accessing a cached version of the PDF?

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Oct 9, 2023

@wrynearson I've made changes and tested a few times. Sometimes the table captions appear above the table and sometime they don't. Figures and equations are still missing numbers every time I've tested. Here is the document I am testing: https://www.earthdata.nasa.gov/apt/documents/journal-pdf-testing/v1.0

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Oct 9, 2023

@wrynearson I also noticed the document title is no longer centered on the document PDF (it is on the journal PDF).

@vgeorge
Copy link
Contributor

vgeorge commented Oct 17, 2023

Table and image numbering in PDFs should now be functional on staging. However, there's a pending issue with equations number in the journal PDF, which I'm currently investigating. They are not incrementing.

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Oct 17, 2023

@vgeorge I'm seeing the incremental issue with the equations on the journal PDF.
The document PDF looks good with one exception. The figure captions should be placed below the image. Table and equations look good on the document PDF.

cc @wrynearson

@wrynearson
Copy link
Member

Hi @bwbaker1, both of these issues (incremental equation numbering and figure caption location) will be ready for your review on staging in about 15 minutes.

@bwbaker1
Copy link
Collaborator Author

@wrynearson Fantastic! I was about to ask about them.

@bwbaker1
Copy link
Collaborator Author

@wrynearson This looks good to me. It's ready for production.

@wrynearson
Copy link
Member

@sunu can you add this to the production deployment?

@sunu
Copy link
Collaborator

sunu commented Oct 24, 2023

@sunu can you add this to the production deployment?

@wrynearson will do!

@bwbaker1
Copy link
Collaborator Author

@wrynearson I believe we can close this ticket since it works correctly for both PDFs on production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants