-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number Tables and place captions above table #681
Comments
@bwbaker1 are you requesting this for the view mode or just the Document and Journal PDFs? |
@wrynearson Just both PDFs. If this is a relatively easy fix, great, otherwise it's not a high priority at the moment. |
@wrynearson What is the LOE to add figure, table, and equation numbers to both view mode and PDFs? This is coming from user feedback. |
Sorry I missed this @bwbaker1. Adding to the PDFs will be low LOE (we already have them for figures and equations) but more complex to add things back into the view mode. @frozenhelium, please correct me if I'm wrong. |
No worries @wrynearson. I want this issue (adding just to PDFs) to be our next priority following the PDF upload, as long as it is rather simple and fast to implement. |
@bwbaker1 this is ready for your review |
@wrynearson This looks good. However, images and equations are no longer numbered on the document PDF. See below. These are still numbered on the journal PDFs. |
@wrynearson The document PDF still isn't generating correctly. See comment. Figures and equations are no longer numbered. And the table captions should be above the table (this is correct on the journal PDF). |
@wrynearson I've made changes and tested a few times. Sometimes the table captions appear above the table and sometime they don't. Figures and equations are still missing numbers every time I've tested. Here is the document I am testing: https://www.earthdata.nasa.gov/apt/documents/journal-pdf-testing/v1.0 |
@wrynearson I also noticed the document title is no longer centered on the document PDF (it is on the journal PDF). |
Table and image numbering in PDFs should now be functional on staging. However, there's a pending issue with equations number in the journal PDF, which I'm currently investigating. They are not incrementing. |
@vgeorge I'm seeing the incremental issue with the equations on the journal PDF. cc @wrynearson |
Hi @bwbaker1, both of these issues (incremental equation numbering and figure caption location) will be ready for your review on staging in about 15 minutes. |
@wrynearson Fantastic! I was about to ask about them. |
@wrynearson This looks good to me. It's ready for production. |
@sunu can you add this to the production deployment? |
@wrynearson will do! |
@wrynearson I believe we can close this ticket since it works correctly for both PDFs on production. |
### Description
There is a need to polish document tables to better fit with standard AGU/APA practices.
Tasks:
Acceptance Criteria:
The text was updated successfully, but these errors were encountered: