Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-publication status from ATBD workflow #553

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

oliverroick
Copy link
Member

Backend changes for #480

  • Removes the in-publication status (PUBLICATION)
  • Removes corresponding permissions, events and email templates
  • Changes permission ACLs so ATBDs can be moved from publication requested to public (PUBLISHED)

Copy link
Collaborator

@naomatheus naomatheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverroick I am still getting 422 unprocessable entity for publications approvals with the change. In api/v2/events.py does the accept_publication status at line ~335 actually need to stay by chance?

@oliverroick
Copy link
Member Author

@naomatheus

In api/v2/events.py does the accept_publication status at line ~335 actually need to stay by chance?

I don't think so, because that would move the publication to the in publication status, which we're not using any more. Do you have the logs from the backend that lead to the error?

Copy link
Collaborator

@naomatheus naomatheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approving. Apologies for the delay, was out having reviewed this.

@naomatheus naomatheus merged commit f15e8e9 into develop Aug 22, 2022
@TimMcCauley TimMcCauley deleted the publication-workflow branch September 5, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants