-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pangeo base image to 2024.06.28 #11
Conversation
There seem to be minor diffs in the outputs that are failing the tests: https://github.com/NASA-IMPACT/pangeo-notebook-veda-image/actions/runs/9759072270/job/26935002169 This makes me very happy haha :-) @jsignell - would you like to take a look? Am also happy to regenerate the outputs snapshot and go ahead with this -- looking at the result diff, this definitely seems totally okay. And thank you again @jsignell - having these tests in place makes me feel SO much better about these updates .. |
This PR would just push the image to ecr right? It wouldn't make this image the default one on veda jupyterhub or anything right? If that is the case then yeah I feel fine with you regenerating the output so that we can build the image and then we can do a more thorough test once it's available just since there are some big version upgrades. |
That's correct - pushes to this repo just build and push the images to ECR - it still requires a manual step to replace the image tags in the I tried regenerating the outputs - hopefully the tests will pass now and you'll have an image to test with :) |
@sunu - I tried regenerating the outputs here and re-running the tests, but am still seeing a failure. Do you have any idea of what's going on here? :) |
@sunu thank you! Does it make sense to add this |
@jsignell image is up on ECR - so you can use the Bring Your Own Image option with |
Just want to point out that this version of the pangeo-notebook docker image (as well as the 2024-07-02 version) is still on numpy 1.26. So the geopandas bump to 1.0 is a big deal, but there isn't as much risk as we maybe expected since numpy is still under 2. |
Aha! I should have looked closer - I thought this was bumping @jsignell will follow your advice for whether we should do this update, or wait for a new pangeo base, or however you feel is best. |
I'm running through the docs notebooks to just double check, but my gut is we can probably just do this update without making it any easier for people to use old versions of the image. |
I am having a really weird time with jupyterlab in that image. Hard to say if it's a totally new problem, but I am seeing really jittery scroll and I can easily get to places in the notebook that haven't aren't rendered at all. I also found a few hvplot and maybe rasterio bugs that sidetracked me. So I didn't quite finish evaluating. |
@jsignell I see there's already an updated version 2024.07.02 - should we try just updating to that? It seems like it is still on |
I'm going to close this one as well given #28 |
refs NASA-IMPACT/veda-jupyterhub#40
Upgrade to latest pangeo base image to test with.
cc @jsignell @sunu