Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for pushing to GitHub from the VEDA Hub #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maxrjones
Copy link
Contributor

This PR adds a new section to Usage Examples called JupyterHub. It currently contains one markdown file How to push to GitHub from the VEDA JupyterHub but I think the new section would be helpful for other upcoming improvements (e.g., additional IDEs). While there's some redundancy with the 2i2c docs, I think the 2i2c docs offer cover background and reasons for things being done a certain way (which is useful for their audience), whereas these how-to guides would provide the minimal required explanation for solving a user's problem.

Copy link

github-actions bot commented Aug 6, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-158/
on branch gh-pages at 2024-08-15 20:58 UTC

Copy link
Collaborator

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I did get an error. Probably something that I had set up already that conflicts:

warning: credential.https://gitpro.ttaallkk.top.helper has multiple values
error: cannot overwrite multiple values with a single value
       Use a regexp, --add or --replace-all to change credential.https://gitpro.ttaallkk.top.helper.

Full error:

image

notebooks/quickstarts/github-authentication.md Outdated Show resolved Hide resolved
Co-authored-by: Julia Signell <jsignell@gmail.com>
@maxrjones
Copy link
Contributor Author

Thanks for the review @jsignell! @wildintellect mentioned that this setup may still be confusing to users, so I'm going to try out recording a quick video explanation (hopefully tomorrow). So, I'll hold off on merging this for a short while and may ping you for another review.

that error does seem likely relating to an existing setup. I can add a warning and perhaps we should also include a section in the JupyterHub section of the docs on where users can go to reach out for help. Is the IMPACT slack where that help would happen?

@wildintellect
Copy link
Contributor

Step 1. Clarify that an Org admin has to setup the initial permissions.
Step 2.

Second, you need to authorize the app on the Hub. This needs to be done once every 8 hours.
Does every user need to do this? So basically it's once per working day?
Can we include gh-scoped-creds.ipynb in the docs repo, so that users just need to open it and run it? (we already checkout the docs in Pangeo workspaces)

The whole thing feels reverse order for actual user usage.

  1. Remember to clone your repos with https, NOTE: github token is the alternative to this method
  2. Authorize once per day (Every 8 hours) <- I wonder if we could make a widget or if the jupyter github extension incorporates this
  3. First time Config for Repos/Organizations (maybe mention at top and link to bottom?

Copy link
Contributor

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants