Move out story taxonomies from the interface

NASA-IMPACT · Sep 23, 2024 · c76f97e · c76f97e
1 parent 69269a1
commit c76f97e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/app/scripts/components/stories/hub/container.tsx b/app/scripts/components/stories/hub/container.tsx
@@ -3,7 +3,6 @@ import { useNavigate } from 'react-router';
 
 import { stories, getString } from 'veda';
 import HubContent from './hub-content';
-import { generateTaxonomies } from '$utils/veda-data/taxonomies';
 
 import { useFiltersWithQS } from '$components/common/catalog/controls/hooks/use-filters-with-query';
 import { LayoutProps } from '$components/common/layout-root';
@@ -24,7 +23,6 @@ const allStories = Object.values(stories).map((d) => d!.data).filter(d => !d.isH
 
 function StoriesHub() {
   const controlVars = useFiltersWithQS({navigate: useNavigate()});
-  const storyTaxonomies = generateTaxonomies(allStories);
   return (
     <PageMainContent>
       <LayoutProps
@@ -45,7 +43,6 @@ function StoriesHub() {
           linkProperties={{ LinkElement: SmartLink, pathAttributeKeyName: 'to'}}
           storiesPagePath={STORIES_PATH}
           storiesString={{one: getString('stories').one,other: getString('stories').other}}
-          storyTaxonomies={storyTaxonomies}
         />
       </ContentOverride>
     </PageMainContent>

diff --git a/app/scripts/components/stories/hub/hub-content.tsx b/app/scripts/components/stories/hub/hub-content.tsx
@@ -31,8 +31,8 @@ import {
   TAXONOMY_SOURCE,
   TAXONOMY_TOPICS
 } from '$utils/veda-data/taxonomies';
-
-import { StoryData, Taxonomy } from '$types/veda';
+import { generateTaxonomies } from '$utils/veda-data/taxonomies';
+import { StoryData } from '$types/veda';
 import { UseFiltersWithQueryResult } from '$components/common/catalog/controls/hooks/use-filters-with-query';
 
 const StoryCount = styled(Subtitle)`
@@ -59,18 +59,19 @@ interface HubContentProps {
   allStories: StoryDataWithPath[];
   linkProperties: LinkProperties;
   storiesPagePath: string;
-  storyTaxonomies: Taxonomy[];
   storiesString: {one: string, other: string};
   onFilterchanges: () => UseFiltersWithQueryResult;
 }
 
 export default function HubContent(props:HubContentProps) {
-  const { allStories, linkProperties, storiesPagePath, storyTaxonomies, storiesString, onFilterchanges } = props;
+  const { allStories, linkProperties, storiesPagePath, storiesString, onFilterchanges } = props;
   const browseControlsHeaderRef = useRef<HTMLDivElement>(null);
   const { headerHeight } = useSlidingStickyHeaderProps();
-  const { LinkElement, pathAttributeKeyName } = linkProperties;
   const { search, taxonomies, onAction } = onFilterchanges();
 
+  const { LinkElement, pathAttributeKeyName } = linkProperties;
+  const storyTaxonomies = generateTaxonomies(allStories);
+
   const ButtonLinkProps = {
     forwardedAs: LinkElement,
     [pathAttributeKeyName]: storiesPagePath