Make cookie consent component not to receive mouse events when closed #1177
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
approved these changes
Sep 27, 2024
dzole0311
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #953
Description of Changes
Make cookie consent component not to receive mouse events when closed.
Notes & Questions About Changes
This might be able to be resolved with #1170 , but here is a quick fix.
Validation / Testing
Go to https://veda-ui.netlify.app/exploration?datasets=%5B%5D&taxonomy=%7B%7D , close cookie consent form and try to add datasets. The button click is blocked because we are hiding the component only with opacity. (And check the same work flow on this PR's preview)