Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.7.0-beta.1] modal: some problems via services #1155

Closed
cipchk opened this issue Mar 16, 2018 · 1 comment · Fixed by #1165
Closed

[0.7.0-beta.1] modal: some problems via services #1155

cipchk opened this issue Mar 16, 2018 · 1 comment · Fixed by #1165
Assignees
@wilsoncook

Comments

@cipchk
Copy link
Member

cipchk commented Mar 16, 2018 •
edited
Loading

Version

0.7.0-beta.1

Environment

nothing

Reproduction link

nothing

Steps to reproduce

nothing

What is expected?

1. how callback data via ModalPublicAgent

this.nzModalService.create({
    nzFooter: null,
    nzContent: TestComponent
});

test.component.ts

class TestModalComponent {
    constructor(private modal: ModalPublicAgent) {}

    close() {
        this.modal.destroy(); // not any paramentes
    }
}

2. How to listener closed when footer is null

What is actually happening?

nothing

Other?
@cipchk cipchk changed the title [0.7.0-beta.1] modal: how callback data via ModalPublicAgent [0.7.0-beta.1] modal: some problems via services Mar 16, 2018
wilsoncook added a commit to wilsoncook/ng-zorro-antd that referenced this issue Mar 17, 2018
@wilsoncook
feat(module:modal): add afterClose and more to improve communication …
7a801d2 
…capabilities

close NG-ZORRO#1155
@wilsoncook wilsoncook mentioned this issue Mar 17, 2018
Merged
3 tasks
wilsoncook added a commit to wilsoncook/ng-zorro-antd that referenced this issue Mar 19, 2018
@wilsoncook
feat(module:modal): add afterClose and more to improve communication …
f5410cb 
…capabilities

close NG-ZORRO#1155
vthinkxie pushed a commit that referenced this issue Mar 19, 2018
@wilsoncook @vthinkxie
feat(module:modal): add afterOpen/afterClose/afterAllClose/closeAll/o…
10227b8 
…penModals, adjust the boolean props and changeBodyOverflow and complete testing. (#1165)

* feat(module:modal): add afterClose and more to improve communication capabilities

close #1155

* feat(module:modal): add afterOpen/afterAllClose/closeAll/openModals, adjust the boolean props and changeBodyOverflow, complete testing.

close #1162

* docs(changelog): add 0.7.0-beta.2 changelog for modal
@lock
Copy link

lock bot commented Mar 19, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 19, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@wilsoncook @vthinkxie
feat(module:modal): add afterOpen/afterClose/afterAllClose/closeAll/o…
d19820f 
…penModals, adjust the boolean props and changeBodyOverflow and complete testing. (NG-ZORRO#1165)

* feat(module:modal): add afterClose and more to improve communication capabilities

close NG-ZORRO#1155

* feat(module:modal): add afterOpen/afterAllClose/closeAll/openModals, adjust the boolean props and changeBodyOverflow, complete testing.

close NG-ZORRO#1162

* docs(changelog): add 0.7.0-beta.2 changelog for modal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wilsoncook wilsoncook

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wilsoncook @cipchk