Missing observable boolean checking [nzBeforeUpload]

[KhaledSMQ]

Version

1.5.0

Environment

Angular 6

Reproduction link

https://ng-zorro-antd-start-2cy3cn.stackblitz.io
https://stackblitz.com/edit/ng-zorro-antd-start-2cy3cn

Steps to reproduce

problems comes when i am return observable and i want to cancel by returning switchMap or for any condition or return false or null upload process continue, means returning observable acutely it's not doing any thing only to keep upload async.

What is expected?

the return type must be valid otherwise will not process uploading the file.

What is actually happening?

I think this part is missing to check boolean returned from observable as per the documentation i can return boolean or observable

ng-zorro-antd/components/upload/nz-upload-btn.component.ts

Line 133 in 69ff576

if (processedFileType === '[object File]' || processedFileType === '[object Blob]') {

here my suggestion fix for this issue.

        before.subscribe((processedFile: UploadFile | boolean ) => {
             const processedFileType = Object.prototype.toString.call(processedFile);
        if (processedFileType === '[object File]' || processedFileType === '[object Blob]') {
          this.attachUid(processedFile as UploadFile );
          this.post(processedFile as UploadFile);
     
        } else  if (processedFileType === '[object Boolean]'  && processedFile !== false) {
          this.post(file);
        } 
 

Other?

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.