Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support currently for Slovene language (sl_SI) #2545

Closed
aleksander351 opened this issue Nov 27, 2018 · 6 comments
Closed

No support currently for Slovene language (sl_SI) #2545

aleksander351 opened this issue Nov 27, 2018 · 6 comments
Assignees
@aleksander351
Labels
🌍 i18n 🌈 Feature Request

Comments

@aleksander351
Copy link
Contributor

What problem does this feature solve?

Proper translations for Slovene language.

What does the proposed API look like?

Use sl_SI as language provider.
@aleksander351
Copy link
Contributor Author

The React version of Ant already has the translations:
https://github.com/ant-design/ant-design/blob/master/components/locale-provider/sl_SI.tsx

How can I make a pull request?

@vthinkxie
Copy link
Member

@aleksander351 feel free to create pr, thanks a lot!

aleksander351 added a commit to aleksander351/ng-zorro-antd that referenced this issue Dec 18, 2018
@aleksander351
feat(module:i18n): add Slovenian support, ICU locale sl_SI, NG-ZORRO#…
302d90a 
…2545
@aleksander351 aleksander351 mentioned this issue Dec 18, 2018
Merged
3 tasks
@aleksander351
Copy link
Contributor Author

Commit 302d90a.

@aleksander351
Copy link
Contributor Author

Adding language pack to project not working:
ng add ng-zorro-antd --i18n=sl_SI

@vthinkxie
Copy link
Member

@hsuanxyz plz check this.

@aleksander351
Copy link
Contributor Author

The sl_SI language is working now. But there is one typo. :(
Do I have to make a new PR?
Tagged as bug fix?
Thank you.

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@aleksander351 @vthinkxie
feat(module:i18n): add Slovenian support, ICU locale sl_SI, NG-ZORRO#…
cae3868 
…2545 (NG-ZORRO#2652)

close NG-ZORRO#2545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleksander351 aleksander351

Labels
🌍 i18n 🌈 Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vthinkxie @aleksander351 @hsuanxyz