Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nz-select was marked as touched when initial state of FormControl is disabled #3059

Closed
agmoura opened this issue Mar 11, 2019 · 0 comments · Fixed by #3084
Closed

nz-select was marked as touched when initial state of FormControl is disabled #3059

agmoura opened this issue Mar 11, 2019 · 0 comments · Fixed by #3084
Assignees
@vthinkxie
Labels
🐛 Bug Component: Form Component: Select

Comments

@agmoura
Copy link

agmoura commented Mar 11, 2019

Reproduction link

https://stackblitz.com/edit/angular-klbag5

Steps to reproduce

just run minimal reproduction and verify that the touched state of nz-select component is equal true.

What is expected?

Initial touched state equals false.

What is actually happening?

Initial touched state equals true.

Environment Info
ng-zorro-antd 7.0.1
Browser Chrome 72.0.3626.121 64 bits

This behavior only happens if the initial disabled state is true. I noticed that touched state is changed at ngAfterViewInit lifecycle hook.
@vthinkxie vthinkxie mentioned this issue Mar 13, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Mar 14, 2019
@vthinkxie
fix(module:select): fix select init touched state error when disabled (…
ba9d454 
…#3084)

close #3059
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
fix(module:select): fix select init touched state error when disabled (…
d28b2fd 
…NG-ZORRO#3084)

close NG-ZORRO#3059
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:select): fix select init touched state error when disabled (…
f75b99e 
…NG-ZORRO#3084)

close NG-ZORRO#3059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
🐛 Bug Component: Form Component: Select
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:select): fix select init touched state error when disabled
3 participants
@vthinkxie @wzhudev @agmoura