Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:switch): support fully control by user #1514

Merged
merged 1 commit into from
May 24, 2018
Merged

feat(module:switch): support fully control by user #1514

merged 1 commit into from
May 24, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

close #1481

Other information

@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #1514 into master will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   96.92%   96.93%   +<.01%     
==========================================
  Files         222      222              
  Lines        9507     9512       +5     
  Branches     1297     1298       +1     
==========================================
+ Hits         9215     9220       +5     
  Misses         42       42              
  Partials      250      250
Impacted Files Coverage Δ
components/switch/nz-switch.component.ts 98.66% <93.33%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44296e...17c4792. Read the comment docs.

@vthinkxie vthinkxie merged commit 70ca8bd into NG-ZORRO:master May 24, 2018
@vthinkxie vthinkxie deleted the switch-prevent branch October 10, 2018 02:50
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to toggle switch state async
1 participant