-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use ng-packagr to generate library #1747
Conversation
components/tsconfig.json
Outdated
"annotateForClosureCompiler": true, | ||
"skipTemplateCodegen": true, | ||
"strictMetadataEmit": true, | ||
"fullTemplateTypeCheck": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enabled once our lib could pass it.
183b811
to
42cf30f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 466 466
Lines 11173 11173
Branches 1461 1461
=======================================
Hits 10735 10735
Misses 126 126
Partials 312 312
Continue to review full report at Codecov.
|
Previously I thought the |
Found the |
Great, it seems that there are no break changes now. |
@vthinkxie The CSS path is still breaking, previously:
Now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsuanxyz please add back some shell scripts.
This reverts commit ea2f41e.
…G-ZORRO#1865) revert: "build: use ng-packagr to generate library (NG-ZORRO#1747)"
…G-ZORRO#1865) revert: "build: use ng-packagr to generate library (NG-ZORRO#1747)"
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Switch to ng-packagr to build package which follows Angular Package Format 6.0.
Highlights:
dependencies
is not allowed byng-packagr
, onlypeerDependencies
can be used;import * as pkg from 'pkg'
are nowimport pkg from 'pkg'
;package.json
no longer used to publish, only for dev purpose now;src
segment;Does this PR introduce a breaking change?
CSS file imports require remove the
/src
segment.Other information