Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): reposition when open the first time #1863

Merged

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1840

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #1863 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
+ Coverage   95.97%   95.98%   +<.01%     
==========================================
  Files         466      466              
  Lines       11217    11220       +3     
  Branches     1474     1475       +1     
==========================================
+ Hits        10766    10769       +3     
  Misses        131      131              
  Partials      320      320
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 96.75% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7a6cb...f6023c5. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the autocomplete/fix-position-in-table branch from a18847f to f6023c5 Compare July 23, 2018 02:46
@hsuanxyz hsuanxyz requested a review from vthinkxie July 24, 2018 03:36
@vthinkxie vthinkxie merged commit c80bc8d into NG-ZORRO:master Aug 3, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
@hsuanxyz hsuanxyz deleted the autocomplete/fix-position-in-table branch October 23, 2018 11:20
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants