Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): fix button loading bug #2251

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(module:button): fix button loading bug #2251

merged 1 commit into from
Oct 10, 2018

Conversation

vthinkxie
Copy link
Member

close #2191

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #2251 into master will decrease coverage by 0.08%.
The diff coverage is 76.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
- Coverage   95.87%   95.78%   -0.09%     
==========================================
  Files         485      485              
  Lines       12136    12145       +9     
  Branches     1625     1628       +3     
==========================================
- Hits        11635    11633       -2     
- Misses        145      152       +7     
- Partials      356      360       +4
Impacted Files Coverage Δ
components/core/util/check.ts 83.33% <70%> (-7.3%) ⬇️
components/button/nz-button.component.ts 93.81% <82.6%> (-6.19%) ⬇️
components/table/nz-table.component.ts 93.88% <0%> (-1.12%) ⬇️
components/tabs/nz-tabset.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8861beb...b4f0125. Read the comment docs.

@vthinkxie vthinkxie merged commit cb71e9b into NG-ZORRO:master Oct 10, 2018
@vthinkxie vthinkxie deleted the refactor-button branch February 26, 2019 07:08
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: Loading state overlays icon when button caption is set dynamically
2 participants