Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix menu error #2450

Closed
wants to merge 1 commit into from
Closed

fix menu error #2450

wants to merge 1 commit into from

Conversation

dulinxi
Copy link
Contributor

@dulinxi dulinxi commented Nov 14, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2449

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2450   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         485      485           
  Lines       12302    12302           
  Branches     1672     1672           
=======================================
  Hits        11791    11791           
  Misses        150      150           
  Partials      361      361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17ea49...437632b. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Nov 14, 2018

@ffey Please clean up your commit message. Refer to our contributing guide.

@dulinxi
Copy link
Contributor Author

dulinxi commented Nov 14, 2018

sorry, It's my fault. I will change it .

@dulinxi dulinxi closed this Nov 14, 2018
@dulinxi dulinxi deleted the fix-menu branch November 14, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants