-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(module:anchor): refactor anchor #2546
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a3189e2
refactor(module:anchor): refactor anchor
cipchk cbf3ef5
chore: add encapsulation:ViewEncapsulation.None
cipchk 7b0342a
chore: add encapsulation:ViewEncapsulation.None
cipchk beae833
chore: fix display style in host
cipchk f298d28
chore: remove :host
cipchk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
import { | ||
ChangeDetectionStrategy, | ||
ChangeDetectorRef, | ||
Component, | ||
ContentChild, | ||
ElementRef, | ||
HostBinding, | ||
Input, | ||
OnDestroy, | ||
OnInit, | ||
TemplateRef | ||
TemplateRef, | ||
ViewEncapsulation | ||
} from '@angular/core'; | ||
|
||
import { NzAnchorComponent } from './nz-anchor.component'; | ||
|
@@ -18,7 +21,9 @@ import { NzAnchorComponent } from './nz-anchor.component'; | |
host : { | ||
'[class.ant-anchor-link]': 'true', | ||
'style' : 'display:block' | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should add encapsulation:ViewEncapsulation.None |
||
}, | ||
encapsulation : ViewEncapsulation.None, | ||
changeDetection : ChangeDetectionStrategy.OnPush | ||
}) | ||
export class NzAnchorLinkComponent implements OnInit, OnDestroy { | ||
|
||
|
@@ -30,6 +35,7 @@ export class NzAnchorLinkComponent implements OnInit, OnDestroy { | |
@Input() | ||
set nzTitle(value: string | TemplateRef<void>) { | ||
if (value instanceof TemplateRef) { | ||
this.titleStr = null; | ||
this.titleTpl = value; | ||
} else { | ||
this.titleStr = value; | ||
|
@@ -40,7 +46,7 @@ export class NzAnchorLinkComponent implements OnInit, OnDestroy { | |
|
||
@HostBinding('class.ant-anchor-link-active') active: boolean = false; | ||
|
||
constructor(public el: ElementRef, private anchorComp: NzAnchorComponent) { | ||
constructor(public el: ElementRef, private anchorComp: NzAnchorComponent, private cdr: ChangeDetectorRef) { | ||
} | ||
|
||
ngOnInit(): void { | ||
|
@@ -53,6 +59,10 @@ export class NzAnchorLinkComponent implements OnInit, OnDestroy { | |
this.anchorComp.handleScrollTo(this); | ||
} | ||
|
||
markForCheck(): void { | ||
this.cdr.markForCheck(); | ||
} | ||
|
||
ngOnDestroy(): void { | ||
this.anchorComp.unregisterLink(this); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will overwrite all style apply to nz-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add styles nz-link {display:block}