Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:input-number): refactor input-number support OnPush &… #2601

Merged
merged 1 commit into from
Dec 7, 2018
Merged

refactor(module:input-number): refactor input-number support OnPush &… #2601

merged 1 commit into from
Dec 7, 2018

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Dec 7, 2018

… nzBlur & nzFocus
close #2340 close #1707 close #1554

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vthinkxie vthinkxie mentioned this pull request Dec 7, 2018
86 tasks
@netlify
Copy link

netlify bot commented Dec 7, 2018

Deploy preview for ng-zorro-master ready!

Built with commit 747a7d0

https://deploy-preview-2601--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2601 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2601      +/-   ##
==========================================
- Coverage   95.64%   95.64%   -0.01%     
==========================================
  Files         495      495              
  Lines       12056    12052       -4     
  Branches     1677     1680       +3     
==========================================
- Hits        11531    11527       -4     
  Misses        167      167              
  Partials      358      358
Impacted Files Coverage Δ
...mponents/input-number/nz-input-number.component.ts 98.98% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb1a99...747a7d0. Read the comment docs.

@vthinkxie vthinkxie merged commit 12a658c into NG-ZORRO:master Dec 7, 2018
@vthinkxie vthinkxie deleted the refactor-input-number branch February 26, 2019 07:09
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focus & blur event missing for InputNumber component InputNumber的focus事件和blur事件无效
1 participant