Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:tag): refactor tag support OnPush #2606

Merged
merged 2 commits into from
Dec 11, 2018
Merged

refactor(module:tag): refactor tag support OnPush #2606

merged 2 commits into from
Dec 11, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 8, 2018

Deploy preview for ng-zorro-master ready!

Built with commit 5d57cf2

https://deploy-preview-2606--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #2606 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
- Coverage   95.64%   95.64%   -0.01%     
==========================================
  Files         495      495              
  Lines       12052    12044       -8     
  Branches     1680     1681       +1     
==========================================
- Hits        11527    11519       -8     
  Misses        167      167              
  Partials      358      358
Impacted Files Coverage Δ
components/tag/nz-tag.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a658c...5d57cf2. Read the comment docs.

@vthinkxie vthinkxie mentioned this pull request Dec 11, 2018
86 tasks
@hsuanxyz hsuanxyz merged commit 40efae1 into NG-ZORRO:master Dec 11, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants