Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:icon): update dependency to support namespace #2641

Merged
merged 4 commits into from
Jan 17, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 15, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: update a dependency

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

package.json Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Dec 15, 2018

Deploy preview for ng-zorro-master ready!

Built with commit af690f5

https://deploy-preview-2641--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #2641 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
+ Coverage   95.51%   95.52%   +0.01%     
==========================================
  Files         518      517       -1     
  Lines       12292    12258      -34     
  Branches     1697     1691       -6     
==========================================
- Hits        11741    11710      -31     
+ Misses        191      189       -2     
+ Partials      360      359       -1
Impacted Files Coverage Δ
components/icon/nz-icon-test.module.ts 100% <100%> (ø)
components/icon/nz-icon.service.ts 98.27% <100%> (+0.06%) ⬆️
components/icon/nz-icon.directive.ts 96.29% <100%> (+3.7%) ⬆️
components/core/util/convert.ts 82.6% <0%> (-3.11%) ⬇️
components/icon/public-api.ts
components/icon/index.ts
components/pagination/nz-pagination.component.ts 100% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852ad73...af690f5. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit a2000fa into NG-ZORRO:master Jan 17, 2019
@wzhudev wzhudev deleted the icon-upgrade branch January 17, 2019 12:05
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants