Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix searching error when nzOptions is an empty … #2846

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 28, 2019

…array

  • update empty demos

close #2784

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2784

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8cc14bc

https://deploy-preview-2846--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #2846 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2846      +/-   ##
==========================================
- Coverage    95.5%   95.49%   -0.01%     
==========================================
  Files         523      523              
  Lines       12236    12243       +7     
  Branches     1668     1669       +1     
==========================================
+ Hits        11686    11692       +6     
  Misses        197      197              
- Partials      353      354       +1
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 95.74% <100%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f21d0...8cc14bc. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit e33cc50 into NG-ZORRO:master Feb 13, 2019
@wzhudev wzhudev deleted the cascader-empty branch February 13, 2019 09:05
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
NG-ZORRO#2846)

* fix(module:cascader): fix searching error when nzOptions is an empty array

* update empty demos

close NG-ZORRO#2784

* test: add test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
NG-ZORRO#2846)

* fix(module:cascader): fix searching error when nzOptions is an empty array

* update empty demos

close NG-ZORRO#2784

* test: add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cascader: support empty options in search mode
3 participants