Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:auto-complete): close panel when the trigger element blur #2916

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2885

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz changed the title Fix/autocomplete focus blur feat(module:auto-complete): close panel when the trigger element blur Feb 18, 2019
@netlify
Copy link

netlify bot commented Feb 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 53593e6

https://deploy-preview-2916--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #2916 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2916      +/-   ##
==========================================
+ Coverage   97.36%   97.36%   +<.01%     
==========================================
  Files         524      524              
  Lines       11040    11041       +1     
  Branches      782      782              
==========================================
+ Hits        10749    10750       +1     
  Misses        190      190              
  Partials      101      101
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 99.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4391112...53593e6. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 1e075f9 into NG-ZORRO:master Feb 19, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…NG-ZORRO#2916)

* feat(module:auto-complete): close panel when the trigger element blur

close NG-ZORRO#2885

* test(module:auto-complete): add the feat test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…NG-ZORRO#2916)

* feat(module:auto-complete): close panel when the trigger element blur

close NG-ZORRO#2885

* test(module:auto-complete): add the feat test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants