Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update responseRequiredLabel for no-response config #2935

Merged
merged 1 commit into from
Feb 20, 2019
Merged

chore: update responseRequiredLabel for no-response config #2935

merged 1 commit into from
Feb 20, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

wzhudev
wzhudev approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 815bfe8 into NG-ZORRO:master Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

Merging #2935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2935   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files         524      524           
  Lines       11042    11042           
  Branches      782      782           
=======================================
  Hits        10751    10751           
  Misses        190      190           
  Partials      101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fde8c...f4c2ebb. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f4c2ebb

https://deploy-preview-2935--ng-zorro-master.netlify.com

MagicWang pushed a commit to MagicWang/ng-zorro-antd that referenced this pull request Mar 1, 2019
@vthinkxie
refactor(module:cascader): refactor cascader (NG-ZORRO#2516)
a7fc06d 
* refactor(module:cascader): refactor cascader

close NG-ZORRO#2935
ref NG-ZORRO#2198

* fix(module:cascader): fix isFocused access
@hsuanxyz hsuanxyz deleted the github/no-response branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
chore: update responseRequiredLabel for no-response config (NG-ZORR…
1f5d51c 
…O#2935)
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@vthinkxie
refactor(module:cascader): refactor cascader (NG-ZORRO#2516)
f1dfb9c 
* refactor(module:cascader): refactor cascader

close NG-ZORRO#2935
ref NG-ZORRO#2198

* fix(module:cascader): fix isFocused access
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
chore: update responseRequiredLabel for no-response config (NG-ZORR…
8b9643d 
…O#2935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsuanxyz @wzhudev