Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:button): support link type #3503

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 68f7bad

https://deploy-preview-3503--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented May 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 58587d9

https://deploy-preview-3503--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #3503 into master will decrease coverage by 0.04%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3503      +/-   ##
==========================================
- Coverage    95.6%   95.56%   -0.05%     
==========================================
  Files         609      609              
  Lines       13250    13264      +14     
  Branches     1810     1812       +2     
==========================================
+ Hits        12668    12676       +8     
- Misses        197      200       +3     
- Partials      385      388       +3
Impacted Files Coverage Δ
components/button/demo/basic.ts 100% <ø> (ø) ⬆️
components/button/demo/disabled.ts 100% <ø> (ø) ⬆️
components/button/demo/size.ts 100% <ø> (ø) ⬆️
components/button/nz-button.component.ts 94.11% <ø> (ø) ⬆️
components/button/demo/ghost.ts 100% <ø> (ø) ⬆️
components/button/demo/block.ts 100% <ø> (ø) ⬆️
components/core/wave/nz-wave.directive.ts 85% <64.28%> (-11.16%) ⬇️
components/core/wave/nz-wave-renderer.ts 87.87% <66.66%> (ø) ⬆️
components/select/nz-option-container.component.ts 95.34% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6342657...58587d9. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenqi73 wenqi73 merged commit 050f141 into NG-ZORRO:master Jun 5, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:button): support link type

close NG-ZORRO#3479

* docs(module:button): fix demo

* feat(module:core): wave directive support disable
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:button): support link type

close NG-ZORRO#3479

* docs(module:button): fix demo

* feat(module:core): wave directive support disable
@hsuanxyz hsuanxyz deleted the feat/button-type branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants