Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages/about #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pages/about #29

wants to merge 4 commits into from

Conversation

bellblex
Copy link
Contributor

Closes [#19]

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

❌ Deploy Preview for websiteae failed.

Name Link
🔨 Latest commit d17a88c
🔍 Latest deploy log https://app.netlify.com/sites/websiteae/deploys/66e641fe49c7820008096796

@bellblex
Copy link
Contributor Author

bellblex commented Aug 28, 2024 •
edited
Loading

Need to have a closer look at payload

rubuy-74
rubuy-74 requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think the departments boxes could have more padding.

image

rubuy-74
rubuy-74 requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice, but I just have some small comments.

app/(site)/about/MenuDescription.tsx Outdated Show resolved Hide resolved
app/(site)/about/MenuDescription.tsx Outdated Show resolved Hide resolved
app/(site)/about/page.tsx Show resolved Hide resolved
app/(site)/sport/teams/LineupsSlider.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubuy-74 rubuy-74 rubuy-74 approved these changes

@vitormpp vitormpp Awaiting requested review from vitormpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bellblex @rubuy-74