Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change also luxset with vp-nextfitruncard #1767

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

niclaurenti
Copy link
Contributor

This PR's aim is to change the also luxset (if present) with vp-nextfitruncard, and set it to the input fit.

In this case there's no need to change also the luxseed since it is used only by the last iteration of the fit, i.e. when additional_errors is set to True (operation that has to be done manually since one in principle could do as many iterations as he wishes)

@RoyStegeman
Copy link
Member

RoyStegeman commented Jul 3, 2023

What about the seed? Oops should have read, sorry!

@niclaurenti
Copy link
Contributor Author

What about the seed?

In this case there is no need to change it since it will never be used until the last iteration of the fit. So even if all the runcards of the iterated fits will have the same luxseed it will be actually used only in the last one (the une in which the additional errors are enabled).
But if you want for me it's perfectly fine to change also the seed

Copy link
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - the seed is not something that's included in the loss function of previous iterations so it doesn't need to change.

@niclaurenti niclaurenti merged commit 2ecddfa into master Jul 3, 2023
4 checks passed
@niclaurenti niclaurenti deleted the qed-nextfitruncard branch July 3, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants