Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel replicas with varying tr-vl masks #1788

Merged
merged 33 commits into from
Feb 22, 2024
Merged

Parallel replicas with varying tr-vl masks #1788

merged 33 commits into from
Feb 22, 2024

Commits on Feb 20, 2024

  1. Implemented parallel replicas with varying trvl mask layers

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    101056e View commit details
    Browse the repository at this point in the history

  2. Added lru caches to speed up validphys multi-replica initalization

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    90674bd View commit details
    Browse the repository at this point in the history

  3. Apply black, isort to modified files

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5db86f1 View commit details
    Browse the repository at this point in the history

  4. Made isinstance call more elegant 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @goord @scarlehoff @APJansen
    2 people authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c7b1d14 View commit details
    Browse the repository at this point in the history

  5. Simplify LossInvCovmat for diagonal cases

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9663a63 View commit details
    Browse the repository at this point in the history

  6. Simplified replica stacking of experimental data in model setup

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    799c12c View commit details
    Browse the repository at this point in the history

  7. Removed axis argument from mask layer and determine output shape at b… 

    …uild stage
    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ba6bb59 View commit details
    Browse the repository at this point in the history

  8. Return -1 as stop epoch whenever the final epoch object is not create… 

    …d yet
    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b2edf4b View commit details
    Browse the repository at this point in the history

  9. Give warning on parallel multi-replica single-point datasets

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    06c59ff View commit details
    Browse the repository at this point in the history

  10. Add default parameters to tr_masks to fix unit tests

    @goord @APJansen
    goord authored and APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    170c13f View commit details
    Browse the repository at this point in the history

  11. Revert change to runcard

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    36edbdb View commit details
    Browse the repository at this point in the history

  12. Generalise import of operations

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2bc758b View commit details
    Browse the repository at this point in the history

  13. Restore EKO import

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    868a9a4 View commit details
    Browse the repository at this point in the history

  14. Revert "Added lru caches to speed up validphys multi-replica initaliz… 

    …ation" (done in separate PR now)

This reverts commit 5bb24d8.
    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    458469e View commit details
    Browse the repository at this point in the history

  15. Remove unused index in loop

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    916249d View commit details
    Browse the repository at this point in the history

  16. Refactor list comprehensions

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b2ad20e View commit details
    Browse the repository at this point in the history

  17. Remove unused functools import

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b337bf7 View commit details
    Browse the repository at this point in the history

  18. Fix shape of input and mask in the Mask layer, and adjust test.

    @APJansen
    APJansen committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c2e4935 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Simplify einsum call 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a8da0db View commit details
    Browse the repository at this point in the history

  2. Use enumerate instead of indexing

    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2bbf864 View commit details
    Browse the repository at this point in the history

  3. Simplify branching on kernel shape (also rename tmp->obs_diff, 

    res->loss)
    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1d91484 View commit details
    Browse the repository at this point in the history

  4. be explicit about axis 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d994895 View commit details
    Browse the repository at this point in the history

  5. Remove check for multiple replicas 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c260f14 View commit details
    Browse the repository at this point in the history

  6. keys -> items in loop as a value was being used

    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a4026e1 View commit details
    Browse the repository at this point in the history

  7. Remove deprecated comment

    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d63115b View commit details
    Browse the repository at this point in the history

  8. Clarify branching in loss

    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    49904a3 View commit details
    Browse the repository at this point in the history

  9. Simplified pos_info and integ_info usage in model_trainer

    @goord
    goord committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    db24f63 View commit details
    Browse the repository at this point in the history

  10. Fix bug in losses, incorrectly determining number of replicas

    @APJansen
    APJansen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f6e9bac View commit details
    Browse the repository at this point in the history

  11. Made construction of replicas_info more readable

    @goord
    goord committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    66f1068 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/trvl-mask-layers' into trvl-mask… 

    …-layers
    @goord
    goord committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2cd1701 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Simplify replicas_info further

    @APJansen
    APJansen committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bc76939 View commit details
    Browse the repository at this point in the history

  2. Automatically regenerated regressions from PR 1788, branch trvl-mask-… 

    …layers.
    Redo regressions bot committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    44901f0 View commit details
    Browse the repository at this point in the history

  3. Add comment on flattening 

    Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
    @APJansen @scarlehoff
    APJansen and scarlehoff committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a7dfc0d View commit details
    Browse the repository at this point in the history