-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theory covmat for higher twist #1865
Conversation
Just a quick comment (also just as a reminder to myself) - we should allow for both theory covmat through scalevar and HT covmat to be added simultaneously. |
A comment so I don't forget, I think before doing this we should remove all the thcovmat stuff thst is not being used. That would facilitate adding new components (because one would know where to look...). |
Since I don't expect this PR to be one of the ones that's open for an infinite amount of time I think that would imply removing that functionality now-ish. I don't mind, but I had understood you wanted to keep it as it currently is to make sure nobody is using it (especially |
No, I put the exception to make sure nobody was using it but I'd rather remove it as soon as possible. |
4bc6c28
to
2bc6d2b
Compare
I had a look at the fitting part, and, it looks like it should work now even though it is "by accident". This is because the covmat is saved under the same name as a scalevar covmat and for the fit they will be treated in the same way. While the HT covmat implementation is living in this branch that is not a problem so with the pipeline set up all that's left to do before performing a fit is to make sure the computation of the covmat is done correctly. |
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
4862250
to
4e9c903
Compare
We want to add a covmat to account for higher twist effects. Therefore the covmat should be constructed similar to a 3pt prescirption where$\Delta^\pm = \pm \sigma_\mathrm{obs}\frac{c}{Q^2(1-x)}$ for come coefficient $c$ .
impact on the datapoints is as follows: https://vp.nnpdf.science/xee4YTRKSAmRmN3iUZfkIg==