Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to weight loading/saving for compatibility with Keras 3 #2042

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Apr 10, 2024

The tests failing elsewhere are due to a change in the Dense layer in keras. We are extending (and exploiting) the internal of their layer so changes there break things here.

Note, old weights still load fine (that's why only the saving was failing) since they have kept a legacy loader.

But, just in case, I'm updating also the weights to the new format. Once the regression pass I'll push the updated weights.

I've also re-enabled single_dense since it is very useful for debugging. I'll add a test for it. It also gives a fall-back that should work even if the internals of keras we rely upon change.

edit: a pity that I cannot change the description of the commit without force-pushing, the last one should obviously be "add check for single dense" :__

@scarlehoff scarlehoff added the redo-regressions Recompute the regression data label Apr 10, 2024
Copy link
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In particular I like the green tick!

@scarlehoff scarlehoff merged commit 787f001 into master Apr 10, 2024
6 checks passed
@scarlehoff scarlehoff deleted the fix_keras_3 branch April 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redo-regressions Recompute the regression data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants