-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a conda release of v0.8.x #300
Comments
Yes, we'd need to fix conda-forge/pineappl-feedstock#40 first to make that happen, but so far I haven't had the time to look into it. |
Btw, @cschwan if you need someone to experiment with the macos feedstock please let me know. |
Yes, I'm not sure why the installation of the wheels breaks on macOS: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=980538&view=logs&j=9c5ef928-2cd6-52e5-dbe6-9d173a7d951b&t=20c71c51-4b27-578b-485d-06ade2de1d00&l=1628. The corresponding line in the build script should be: https://github.com/conda-forge/pineappl-feedstock/blob/ac754fd6f8683acc0b4e4b7500923d2d7ce4b2e1/recipe/build.sh#L10. |
Thanks, I will have a look. |
I can both build the wheel and install it locally so I am not sure yet what is the issue. The only difference between what is in the remote and what I have locally is that even though I am also using One thing that I don't understand is that it seems that it is trying to install the wheel with a different python version from the (c)python from which the wheel was build: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=980538&view=logs&j=a8dee1cf-d17f-5cb0-b53f-4a93dfdbfb0c&t=d9dbf137-9a7f-5666-c60c-9e1b2fc31445&l=1616 I will still keep digging. |
@Radonirinaunimi I added you as a code owner to the conda-forge repository, so you should have write access now. Let me know if it doesn't work! |
Perfect! Thanks @cschwan. |
@Radonirinaunimi I released 0.8.2 yesterday, so you can either abandon 0.8.1 and proceed with 0.8.2 (merging 0.8.2 will close the PR for 0.8.1) or you continue with 0.8.1 and repeat your changes with 0.8.2 after you've merged 0.8.1. |
Yes, I am continuing directly with Some of the MacOS platforms are now working (status) but there are still some failures. |
The remaining error: tar: Error opening archive: Unrecognized archive format seems to be due to the I am not sure what could be done here as this is really unpredictable. |
Now, everything passed ... |
You just need the package to compile in the CI once. Maybe leave an issue open in the feedstock to remind yourself of the issue, but once the package is compiled (and uploaded to conda-forge) the unpredictability doesn't matter anymore. |
So, @cschwan, @scarlehoff I guess we can then merge conda-forge/pineappl-feedstock#44? |
I'll merge it. |
I had a closer look into build logs and it seems that the version isn't properly set and therefore |
Very strange, it doesn't seem to be entirely reproducible. Should the error
Most likely the |
@Radonirinaunimi @scarlehoff please check that v0.8.2 works via Conda and then please close the Issue. |
That error is indeed very strange. I am not really sure what is going on here. But the |
Would it be possible to also have the conda release of
v0.8.0
? This would be needed for various tests in NNPDF (see for example NNPDF/nnpdf#2110).The text was updated successfully, but these errors were encountered: