Bump pineappl version #2129
Merged
Bump pineappl version #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomomagni
approved these changes
Jul 18, 2024
|
@Radonirinaunimi shouldn't we update also the |
Yes, I will do so once this NNPDF/pineappl#300 is resolved. I will have time to look into it more tomorrow (if not today). |
|
The problem is that the conda package for pineappl seems to not be working at the moment conda-forge/pineappl-feedstock#41 |
|
Are you happy with this @scarlehoff? |
scarlehoff
approved these changes
Jul 23, 2024
cschwan
reviewed
Jul 23, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pineappl v0.8.1 is out we can update here. In principle, these changes are also introduced in #2110 but given that this is needed to make pineko work (NNPDF/pineko#181) it would be better to have this in master first.
Tests relying on conda are still failing because of NNPDF/pineappl#300.