-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1 degree #51
Add 1 degree #51
Conversation
parm/MOM_input_template100
Outdated
the Modular Ocean Model (MOM6), a numerical ocean model developed at NOAA-GFDL. | ||
Where appropriate, parameters use usually given in MKS units. | ||
|
||
This particular file is for the example in OM4_025. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file for quarter degree? If the setting is changed for 1 degree, maybe add a comment line to specify what has been changed from 025 (grid info, time step, phys scheme, etc),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the question, otherwise the code looks good to me.
The MOM_input file for 1deg appears to be a copy of the 1/4 deg input but w/ the domain size and data files changed. Jiande had explained that each MOM resolution required it's own MOM_input. I believe we should obtain a 1-deg MOM_input from Jiande. |
…d from the 0.25-degree MOM6 parameters.
There seem to be multiple differences in things like the value of mixing parameters etc between this file and what Jiande gave me for the 1deg MOM6. I don't know enough about all of MOM's parameter settings to know which can be safely left at the 025 values and which need to be changed (and to what) for the lower resolution. |
New baselines are generated with the new MOM_input_template100 file. This pull request is ready for review. |
Description
One-degree regression tests are added to the regression test system.
Fixes #49
Testing:
New baselines are generated on Hera and Orion.
The following 4 new regression tests are added:
cpld_datm_mom6_cice5_100_cold_cfsr
cpld_datm_mom6_cice5_100_2d_cfsr
cpld_datm_mom6_cice5_100_cold_gefs
cpld_datm_mom6_cice5_100_2d_gefs
Co-authored by: jiandewang