Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment indentation #2526

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix comment indentation #2526

merged 1 commit into from
Apr 23, 2024

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Apr 23, 2024 •
edited
Loading

Description

Corrects comment indentation to satisfy PEP-8 complaints from pynorms.

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Comment whitespace only - no testing needed.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@WalterKolczynski-NOAA
Fix comment indentation
e814be6 
Corrects comment indentation to satisfy PEP-8 complaints from pynorms.
TerrenceMcGuinness-NOAA
TerrenceMcGuinness-NOAA approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks important to me

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit f11bf3d into develop Apr 23, 2024
5 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the hotfix/pynorms branch April 23, 2024 20:00
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request May 2, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
647282e 
* upstream/develop:
  Update gfs_utils for Gaea (NOAA-EMC#2556)
  Updated GEMPAK version and APRUN launcher. (NOAA-EMC#2555)
  Utilize scale-dependent localization for atmospheric analysis (NOAA-EMC#2542)
  Remove implicit symlink names (NOAA-EMC#2527)
  Fixes sea ice archiving (NOAA-EMC#2541)
  Link ensemble analysis increment files to COMROOT for warm_start (NOAA-EMC#2553)
  Launch Multiple Platforms to Jenkins with polling (NOAA-EMC#2548)
  Turn C48mx500_3DVarAOWCDA back on  (NOAA-EMC#2543)
  Add option to link different orog/ugwd fix files for global nest (NOAA-EMC#2532)
  Retire AWIPS GRIB1 products (NOAA-EMC#2547)
  Add CADS use flexibility (NOAA-EMC#2540)
  Hot fix for bash CI on WCOSS2 (NOAA-EMC#2536)
  Fix comment indentation (NOAA-EMC#2526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterKolczynski-NOAA @aerorahul @TerrenceMcGuinness-NOAA