Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variables that have intrinsic function and keyword argument names to different descriptive names #1328

Closed
mcallic2 opened this issue Aug 10, 2023 · 0 comments · Fixed by #1394
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@mcallic2
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As the modern fortran language has expanded and been improved upon, there are many variables within the FMS codebase that have the same names as these keywords or functions.

For example, data is used in many instances throughout the code as a variable name whether it be a dummy argument or module level variable. data has been defined as a keyword for the release of Fortran 77. The functionality of the data keyword is such that it initializes variables, substrings, arrays, and array elements.

This is just one of many examples of these keywords/functions that are now defined in newer versions (Fortran 77 and above). Some others that have been found in FMS are: name, unit, etc.

Describe the solution you'd like
I propose to change these variable names that have other functionality to different, more descriptive variable names

@mcallic2 mcallic2 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Aug 10, 2023
@abrooks1085 abrooks1085 mentioned this issue Dec 4, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant